shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

Re-enable MSVC C4141 diagnostic; NFC (#182586)

Browse Source 
From MSDN:

https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4141?view=msvc-170

> 'modifier': used more than once

This diagnostic was disabled in e11ce62707c8e0f51fce06097f71a97d02283d7a
due to triggering repeatedly for combinations of __forceinline and
inline. However, local testing shows that this diagnostic is no longer
emitted and so I believe this can be re-enabled.
This commit is contained in:
Aaron Ballman 2026-02-23 09:20:35 -05:00 committed by GitHub
parent 595c5bcdc5
commit 630a4185d4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
llvm/cmake/modules/HandleLLVMOptions.cmake
View File

@ -745,7 +745,6 @@ if (MSVC)
if (NOT CLANG_CL)
set(msvc_warning_flags
# Disabled warnings.
-wd4141 # Suppress ''modifier' : used more than once' (because of __forceinline combined with inline)
-wd4146 # Suppress 'unary minus operator applied to unsigned type, result still unsigned'
-wd4244 # Suppress ''argument' : conversion from 'type1' to 'type2', possible loss of data'
-wd4267 # Suppress ''var' : conversion from 'size_t' to 'type', possible loss of data'