shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[mlir][scf] Quick fix to scf.execute_region no_inline (#154931)

Browse Source 
Asm printer should exclude `no_inline` attr during printing optional
attrs at the bottom.
This commit is contained in:
Jungwook Park 2025-08-22 13:11:27 +01:00 committed by GitHub
parent 7c1d2467f1
commit b149fc7755
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
mlir/lib/Dialect/SCF/IR/SCF.cpp
View File

@ -157,8 +157,7 @@ void ExecuteRegionOp::print(OpAsmPrinter &p) {
p.printRegion(getRegion(), p.printRegion(getRegion(),
/*printEntryBlockArgs=*/false, /*printEntryBlockArgs=*/false,
/*printBlockTerminators=*/true); /*printBlockTerminators=*/true);
p.printOptionalAttrDict((*this)->getAttrs(), /*elidedAttrs=*/{"no_inline"});
p.printOptionalAttrDict((*this)->getAttrs());
} }
LogicalResult ExecuteRegionOp::verify() { LogicalResult ExecuteRegionOp::verify() {

2
mlir/test/Dialect/SCF/canonicalize.mlir
View File

@ -1479,7 +1479,7 @@ func.func @execute_region_no_inline() {
// CHECK-NEXT: scf.execute_region // CHECK-NEXT: scf.execute_region
// CHECK-NEXT: %[[VAL:.*]] = "test.val"() : () -> i64 // CHECK-NEXT: %[[VAL:.*]] = "test.val"() : () -> i64
// CHECK-NEXT: scf.yield %[[VAL]] : i64 // CHECK-NEXT: scf.yield %[[VAL]] : i64
// CHECK-NEXT: } // CHECK-NOT: no_inline
// ----- // -----