Jeremy Morse e6bf48d110
[X86] Don't request 0x90 nop filling in p2align directives (#110134)
As of rev ea222be0d, LLVMs assembler will actually try to honour the
"fill value" part of p2align directives. X86 printed these as 0x90, which
isn't actually what it wanted: we want multi-byte nops for .text
padding. Compiling via a textual assembly file produces single-byte
nop padding since ea222be0d but the built-in assembler will produce
multi-byte nops. This divergent behaviour is undesirable.

To fix: don't set the byte padding field for x86, which allows the
assembler to pick multi-byte nops. Test that we get the same multi-byte
padding when compiled via textual assembly or directly to object file.
Added same-align-bytes-with-llasm-llobj.ll to that effect, updated
numerous other tests to not contain check-lines for the explicit padding.
2024-10-02 11:14:05 +01:00

38 lines
1.4 KiB
LLVM

; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
; RUN: llc < %s -mtriple=x86_64-unknown-linux-gnu -mcpu=atom | FileCheck %s
; RUN: llc < %s -mtriple=x86_64-unknown-linux-gnu -mcpu=atom -filetype=obj -o /dev/null
define void @HUF_writeCTable_wksp() {
; CHECK-LABEL: HUF_writeCTable_wksp:
; CHECK: # %bb.0: # %entry
; CHECK-NEXT: movl $2, %eax
; CHECK-NEXT: movb $-2, %cl
; CHECK-NEXT: .p2align 4
; CHECK-NEXT: .LBB0_1: # %for.body
; CHECK-NEXT: # =>This Inner Loop Header: Depth=1
; CHECK-NEXT: leal 1(%rcx), %edx
; CHECK-NEXT: movb %dl, (%rax)
; CHECK-NEXT: movb %cl, (%rax)
; CHECK-NEXT: leaq 2(%rax), %rax
; CHECK-NEXT: addb $-2, %cl
; CHECK-NEXT: jmp .LBB0_1
entry:
br label %for.body
for.body: ; preds = %for.body, %entry
%indvars.iv8 = phi i64 [ 1, %entry ], [ %indvars.iv.next9.1, %for.body ]
%0 = trunc i64 %indvars.iv8 to i8
%conv = sub i8 0, %0
store i8 %conv, ptr undef, align 1
%indvars.iv.next9 = add nuw nsw i64 %indvars.iv8, 1
%1 = trunc i64 %indvars.iv.next9 to i8
%conv.1 = sub i8 0, %1
%arrayidx.1 = getelementptr inbounds i8, ptr null, i64 %indvars.iv.next9
store i8 %conv.1, ptr %arrayidx.1, align 1
%indvars.iv.next9.1 = add nuw nsw i64 %indvars.iv8, 2
br i1 false, label %for.end, label %for.body
for.end: ; preds = %for.body
ret void
}