Detected on targets older then gfx10 (e.g. gfx9) for constants that are too large to be inlined (constant are sgpr by default). In med3 combine it is expected that regbankselect maps all operands of min/max we try to match to vgpr. However constants are mapped to sgpr and there will be a sgpr-to-vgpr copy. Matchers look through sgpr-to-vgpr copies and return sgpr and these break constant bus restriction. Build med3 with all vgpr operands. Use existing sgpr-to-vgpr copies for matched sgprs. If there is no such copy (not expected) build one. Differential Revision: https://reviews.llvm.org/D114700
296 lines
10 KiB
C++
296 lines
10 KiB
C++
//=== lib/CodeGen/GlobalISel/AMDGPURegBankCombiner.cpp ---------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This pass does combining of machine instructions at the generic MI level,
|
|
// after register banks are known.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "AMDGPU.h"
|
|
#include "AMDGPULegalizerInfo.h"
|
|
#include "AMDGPURegisterBankInfo.h"
|
|
#include "GCNSubtarget.h"
|
|
#include "MCTargetDesc/AMDGPUMCTargetDesc.h"
|
|
#include "llvm/CodeGen/GlobalISel/Combiner.h"
|
|
#include "llvm/CodeGen/GlobalISel/CombinerHelper.h"
|
|
#include "llvm/CodeGen/GlobalISel/CombinerInfo.h"
|
|
#include "llvm/CodeGen/GlobalISel/GISelKnownBits.h"
|
|
#include "llvm/CodeGen/GlobalISel/MIPatternMatch.h"
|
|
#include "llvm/CodeGen/MachineDominators.h"
|
|
#include "llvm/CodeGen/TargetPassConfig.h"
|
|
#include "llvm/Target/TargetMachine.h"
|
|
#define DEBUG_TYPE "amdgpu-regbank-combiner"
|
|
|
|
using namespace llvm;
|
|
using namespace MIPatternMatch;
|
|
|
|
class AMDGPURegBankCombinerHelper {
|
|
protected:
|
|
MachineIRBuilder &B;
|
|
MachineFunction &MF;
|
|
MachineRegisterInfo &MRI;
|
|
const RegisterBankInfo &RBI;
|
|
const TargetRegisterInfo &TRI;
|
|
CombinerHelper &Helper;
|
|
|
|
public:
|
|
AMDGPURegBankCombinerHelper(MachineIRBuilder &B, CombinerHelper &Helper)
|
|
: B(B), MF(B.getMF()), MRI(*B.getMRI()),
|
|
RBI(*MF.getSubtarget().getRegBankInfo()),
|
|
TRI(*MF.getSubtarget().getRegisterInfo()), Helper(Helper){};
|
|
|
|
bool isVgprRegBank(Register Reg);
|
|
Register getAsVgpr(Register Reg);
|
|
|
|
struct MinMaxMedOpc {
|
|
unsigned Min, Max, Med;
|
|
};
|
|
|
|
struct Med3MatchInfo {
|
|
unsigned Opc;
|
|
Register Val0, Val1, Val2;
|
|
};
|
|
|
|
MinMaxMedOpc getMinMaxPair(unsigned Opc);
|
|
|
|
template <class m_Cst, typename CstTy>
|
|
bool matchMed(MachineInstr &MI, MachineRegisterInfo &MRI, MinMaxMedOpc MMMOpc,
|
|
Register &Val, CstTy &K0, CstTy &K1);
|
|
|
|
bool matchIntMinMaxToMed3(MachineInstr &MI, Med3MatchInfo &MatchInfo);
|
|
void applyMed3(MachineInstr &MI, Med3MatchInfo &MatchInfo);
|
|
};
|
|
|
|
bool AMDGPURegBankCombinerHelper::isVgprRegBank(Register Reg) {
|
|
return RBI.getRegBank(Reg, MRI, TRI)->getID() == AMDGPU::VGPRRegBankID;
|
|
}
|
|
|
|
Register AMDGPURegBankCombinerHelper::getAsVgpr(Register Reg) {
|
|
if (isVgprRegBank(Reg))
|
|
return Reg;
|
|
|
|
// Search for existing copy of Reg to vgpr.
|
|
for (MachineInstr &Use : MRI.use_instructions(Reg)) {
|
|
Register Def = Use.getOperand(0).getReg();
|
|
if (Use.getOpcode() == AMDGPU::COPY && isVgprRegBank(Def))
|
|
return Def;
|
|
}
|
|
|
|
// Copy Reg to vgpr.
|
|
Register VgprReg = B.buildCopy(MRI.getType(Reg), Reg).getReg(0);
|
|
MRI.setRegBank(VgprReg, RBI.getRegBank(AMDGPU::VGPRRegBankID));
|
|
return VgprReg;
|
|
}
|
|
|
|
AMDGPURegBankCombinerHelper::MinMaxMedOpc
|
|
AMDGPURegBankCombinerHelper::getMinMaxPair(unsigned Opc) {
|
|
switch (Opc) {
|
|
default:
|
|
llvm_unreachable("Unsupported opcode");
|
|
case AMDGPU::G_SMAX:
|
|
case AMDGPU::G_SMIN:
|
|
return {AMDGPU::G_SMIN, AMDGPU::G_SMAX, AMDGPU::G_AMDGPU_SMED3};
|
|
case AMDGPU::G_UMAX:
|
|
case AMDGPU::G_UMIN:
|
|
return {AMDGPU::G_UMIN, AMDGPU::G_UMAX, AMDGPU::G_AMDGPU_UMED3};
|
|
}
|
|
}
|
|
|
|
template <class m_Cst, typename CstTy>
|
|
bool AMDGPURegBankCombinerHelper::matchMed(MachineInstr &MI,
|
|
MachineRegisterInfo &MRI,
|
|
MinMaxMedOpc MMMOpc, Register &Val,
|
|
CstTy &K0, CstTy &K1) {
|
|
// 4 operand commutes of: min(max(Val, K0), K1).
|
|
// Find K1 from outer instr: min(max(...), K1) or min(K1, max(...)).
|
|
// Find K0 and Val from inner instr: max(K0, Val) or max(Val, K0).
|
|
// 4 operand commutes of: max(min(Val, K1), K0).
|
|
// Find K0 from outer instr: max(min(...), K0) or max(K0, min(...)).
|
|
// Find K1 and Val from inner instr: min(K1, Val) or min(Val, K1).
|
|
return mi_match(
|
|
MI, MRI,
|
|
m_any_of(
|
|
m_CommutativeBinOp(
|
|
MMMOpc.Min, m_CommutativeBinOp(MMMOpc.Max, m_Reg(Val), m_Cst(K0)),
|
|
m_Cst(K1)),
|
|
m_CommutativeBinOp(
|
|
MMMOpc.Max, m_CommutativeBinOp(MMMOpc.Min, m_Reg(Val), m_Cst(K1)),
|
|
m_Cst(K0))));
|
|
}
|
|
|
|
bool AMDGPURegBankCombinerHelper::matchIntMinMaxToMed3(
|
|
MachineInstr &MI, Med3MatchInfo &MatchInfo) {
|
|
Register Dst = MI.getOperand(0).getReg();
|
|
if (!isVgprRegBank(Dst))
|
|
return false;
|
|
|
|
if (MRI.getType(Dst).isVector())
|
|
return false;
|
|
|
|
MinMaxMedOpc OpcodeTriple = getMinMaxPair(MI.getOpcode());
|
|
Register Val;
|
|
Optional<ValueAndVReg> K0, K1;
|
|
// Match min(max(Val, K0), K1) or max(min(Val, K1), K0). Then see if K0 <= K1.
|
|
if (!matchMed<GCstAndRegMatch>(MI, MRI, OpcodeTriple, Val, K0, K1))
|
|
return false;
|
|
|
|
if (OpcodeTriple.Med == AMDGPU::G_AMDGPU_SMED3 && K0->Value.sgt(K1->Value))
|
|
return false;
|
|
if (OpcodeTriple.Med == AMDGPU::G_AMDGPU_UMED3 && K0->Value.ugt(K1->Value))
|
|
return false;
|
|
|
|
MatchInfo = {OpcodeTriple.Med, Val, K0->VReg, K1->VReg};
|
|
return true;
|
|
}
|
|
|
|
void AMDGPURegBankCombinerHelper::applyMed3(MachineInstr &MI,
|
|
Med3MatchInfo &MatchInfo) {
|
|
B.setInstrAndDebugLoc(MI);
|
|
B.buildInstr(MatchInfo.Opc, {MI.getOperand(0)},
|
|
{getAsVgpr(MatchInfo.Val0), getAsVgpr(MatchInfo.Val1),
|
|
getAsVgpr(MatchInfo.Val2)},
|
|
MI.getFlags());
|
|
MI.eraseFromParent();
|
|
}
|
|
|
|
class AMDGPURegBankCombinerHelperState {
|
|
protected:
|
|
CombinerHelper &Helper;
|
|
AMDGPURegBankCombinerHelper &RegBankHelper;
|
|
|
|
public:
|
|
AMDGPURegBankCombinerHelperState(CombinerHelper &Helper,
|
|
AMDGPURegBankCombinerHelper &RegBankHelper)
|
|
: Helper(Helper), RegBankHelper(RegBankHelper) {}
|
|
};
|
|
|
|
#define AMDGPUREGBANKCOMBINERHELPER_GENCOMBINERHELPER_DEPS
|
|
#include "AMDGPUGenRegBankGICombiner.inc"
|
|
#undef AMDGPUREGBANKCOMBINERHELPER_GENCOMBINERHELPER_DEPS
|
|
|
|
namespace {
|
|
#define AMDGPUREGBANKCOMBINERHELPER_GENCOMBINERHELPER_H
|
|
#include "AMDGPUGenRegBankGICombiner.inc"
|
|
#undef AMDGPUREGBANKCOMBINERHELPER_GENCOMBINERHELPER_H
|
|
|
|
class AMDGPURegBankCombinerInfo final : public CombinerInfo {
|
|
GISelKnownBits *KB;
|
|
MachineDominatorTree *MDT;
|
|
|
|
public:
|
|
AMDGPUGenRegBankCombinerHelperRuleConfig GeneratedRuleCfg;
|
|
|
|
AMDGPURegBankCombinerInfo(bool EnableOpt, bool OptSize, bool MinSize,
|
|
const AMDGPULegalizerInfo *LI,
|
|
GISelKnownBits *KB, MachineDominatorTree *MDT)
|
|
: CombinerInfo(/*AllowIllegalOps*/ false, /*ShouldLegalizeIllegal*/ true,
|
|
/*LegalizerInfo*/ LI, EnableOpt, OptSize, MinSize),
|
|
KB(KB), MDT(MDT) {
|
|
if (!GeneratedRuleCfg.parseCommandLineOption())
|
|
report_fatal_error("Invalid rule identifier");
|
|
}
|
|
|
|
bool combine(GISelChangeObserver &Observer, MachineInstr &MI,
|
|
MachineIRBuilder &B) const override;
|
|
};
|
|
|
|
bool AMDGPURegBankCombinerInfo::combine(GISelChangeObserver &Observer,
|
|
MachineInstr &MI,
|
|
MachineIRBuilder &B) const {
|
|
CombinerHelper Helper(Observer, B, KB, MDT);
|
|
AMDGPURegBankCombinerHelper RegBankHelper(B, Helper);
|
|
AMDGPUGenRegBankCombinerHelper Generated(GeneratedRuleCfg, Helper,
|
|
RegBankHelper);
|
|
|
|
if (Generated.tryCombineAll(Observer, MI, B))
|
|
return true;
|
|
|
|
return false;
|
|
}
|
|
|
|
#define AMDGPUREGBANKCOMBINERHELPER_GENCOMBINERHELPER_CPP
|
|
#include "AMDGPUGenRegBankGICombiner.inc"
|
|
#undef AMDGPUREGBANKCOMBINERHELPER_GENCOMBINERHELPER_CPP
|
|
|
|
// Pass boilerplate
|
|
// ================
|
|
|
|
class AMDGPURegBankCombiner : public MachineFunctionPass {
|
|
public:
|
|
static char ID;
|
|
|
|
AMDGPURegBankCombiner(bool IsOptNone = false);
|
|
|
|
StringRef getPassName() const override {
|
|
return "AMDGPURegBankCombiner";
|
|
}
|
|
|
|
bool runOnMachineFunction(MachineFunction &MF) override;
|
|
|
|
void getAnalysisUsage(AnalysisUsage &AU) const override;
|
|
private:
|
|
bool IsOptNone;
|
|
};
|
|
} // end anonymous namespace
|
|
|
|
void AMDGPURegBankCombiner::getAnalysisUsage(AnalysisUsage &AU) const {
|
|
AU.addRequired<TargetPassConfig>();
|
|
AU.setPreservesCFG();
|
|
getSelectionDAGFallbackAnalysisUsage(AU);
|
|
AU.addRequired<GISelKnownBitsAnalysis>();
|
|
AU.addPreserved<GISelKnownBitsAnalysis>();
|
|
if (!IsOptNone) {
|
|
AU.addRequired<MachineDominatorTree>();
|
|
AU.addPreserved<MachineDominatorTree>();
|
|
}
|
|
MachineFunctionPass::getAnalysisUsage(AU);
|
|
}
|
|
|
|
AMDGPURegBankCombiner::AMDGPURegBankCombiner(bool IsOptNone)
|
|
: MachineFunctionPass(ID), IsOptNone(IsOptNone) {
|
|
initializeAMDGPURegBankCombinerPass(*PassRegistry::getPassRegistry());
|
|
}
|
|
|
|
bool AMDGPURegBankCombiner::runOnMachineFunction(MachineFunction &MF) {
|
|
if (MF.getProperties().hasProperty(
|
|
MachineFunctionProperties::Property::FailedISel))
|
|
return false;
|
|
auto *TPC = &getAnalysis<TargetPassConfig>();
|
|
const Function &F = MF.getFunction();
|
|
bool EnableOpt =
|
|
MF.getTarget().getOptLevel() != CodeGenOpt::None && !skipFunction(F);
|
|
|
|
const GCNSubtarget &ST = MF.getSubtarget<GCNSubtarget>();
|
|
const AMDGPULegalizerInfo *LI
|
|
= static_cast<const AMDGPULegalizerInfo *>(ST.getLegalizerInfo());
|
|
|
|
GISelKnownBits *KB = &getAnalysis<GISelKnownBitsAnalysis>().get(MF);
|
|
MachineDominatorTree *MDT =
|
|
IsOptNone ? nullptr : &getAnalysis<MachineDominatorTree>();
|
|
AMDGPURegBankCombinerInfo PCInfo(EnableOpt, F.hasOptSize(),
|
|
F.hasMinSize(), LI, KB, MDT);
|
|
Combiner C(PCInfo, TPC);
|
|
return C.combineMachineInstrs(MF, /*CSEInfo*/ nullptr);
|
|
}
|
|
|
|
char AMDGPURegBankCombiner::ID = 0;
|
|
INITIALIZE_PASS_BEGIN(AMDGPURegBankCombiner, DEBUG_TYPE,
|
|
"Combine AMDGPU machine instrs after regbankselect",
|
|
false, false)
|
|
INITIALIZE_PASS_DEPENDENCY(TargetPassConfig)
|
|
INITIALIZE_PASS_DEPENDENCY(GISelKnownBitsAnalysis)
|
|
INITIALIZE_PASS_END(AMDGPURegBankCombiner, DEBUG_TYPE,
|
|
"Combine AMDGPU machine instrs after regbankselect", false,
|
|
false)
|
|
|
|
namespace llvm {
|
|
FunctionPass *createAMDGPURegBankCombiner(bool IsOptNone) {
|
|
return new AMDGPURegBankCombiner(IsOptNone);
|
|
}
|
|
} // end namespace llvm
|