Jordan Rupprecht 0fc5786648
[lldb][test] Remove expectedFailureIfFn (#81703)
Switching to modern `unittest` in
5b386158aacac4b41126983a5379d36ed413d0ea needs xfail annotations to be
known prior to test running. In contrast, skipping can happen at any
time, even during test execution.

Thus, `expectedFailureIfFn` inherently doesn't work. Either we eagerly
evaluate the function and use `expectedFailureIf` instead, or we use a
skip annotation to lazily evaluate the function and potentially skip the
test right before it starts.

- For `expectedFailureAndroid`, the intent seems to be that certain
tests _should_ work on android, but don't. Thus, xfail is appropriate,
to ensure the test is re-enabled once those bugs are ever fixed.
- For the other uses in individual tests, those generally seem to be
cases where the test environment doesn't support the setup required by
the test, and so it isn't meaningful to run the test at all. For those,
a drop-in replacement to `skipTestIfFn` works.
2024-02-14 15:53:19 -06:00

120 lines
3.6 KiB
Python

import lldb
from lldbsuite.test.decorators import *
from lldbsuite.test.lldbtest import *
from lldbsuite.test import lldbutil
from lldbgdbserverutils import get_debugserver_exe
import os
import platform
import shutil
import time
import socket
class PlatformSDKTestCase(TestBase):
NO_DEBUG_INFO_TESTCASE = True
# The port used by debugserver.
PORT = 54637
# The number of attempts.
ATTEMPTS = 10
# Time given to the binary to launch and to debugserver to attach to it for
# every attempt. We'll wait a maximum of 10 times 2 seconds while the
# inferior will wait 10 times 10 seconds.
TIMEOUT = 2
def no_debugserver(self):
if get_debugserver_exe() is None:
return "no debugserver"
return None
def port_not_available(self):
s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
if s.connect_ex(("127.0.0.1", self.PORT)) == 0:
return "{} not available".format(self.PORT)
return None
@no_debug_info_test
@skipUnlessDarwin
@skipTestIfFn(no_debugserver)
@skipTestIfFn(port_not_available)
@skipIfRemote
def test_macos_sdk(self):
self.build()
exe = self.getBuildArtifact("a.out")
token = self.getBuildArtifact("token")
# Remove the old token.
try:
os.remove(token)
except:
pass
# Create a fake 'SDK' directory.
test_home = os.path.join(self.getBuildDir(), "fake_home.noindex")
test_home = os.path.realpath(test_home)
macos_version = platform.mac_ver()[0]
sdk_dir = os.path.join(
test_home,
"Library",
"Developer",
"Xcode",
"macOS DeviceSupport",
macos_version,
)
symbols_dir = os.path.join(sdk_dir, "Symbols")
lldbutil.mkdir_p(symbols_dir)
# Save the current home directory and restore it afterwards.
old_home = os.getenv("HOME")
def cleanup():
if not old_home:
del os.environ["HOME"]
else:
os.environ["HOME"] = old_home
self.addTearDownHook(cleanup)
os.environ["HOME"] = test_home
# Launch our test binary.
inferior = self.spawnSubprocess(exe, [token])
pid = inferior.pid
# Wait for the binary to launch.
lldbutil.wait_for_file_on_target(self, token)
# Move the binary into the 'SDK'.
rel_exe_path = os.path.relpath(os.path.realpath(exe), "/")
exe_sdk_path = os.path.join(symbols_dir, rel_exe_path)
lldbutil.mkdir_p(os.path.dirname(exe_sdk_path))
shutil.move(exe, exe_sdk_path)
# Attach to it with debugserver.
debugserver = get_debugserver_exe()
debugserver_args = ["localhost:{}".format(self.PORT), "--attach={}".format(pid)]
self.spawnSubprocess(debugserver, debugserver_args)
# Select the platform.
self.expect("platform select remote-macosx", substrs=[sdk_dir])
# Connect to debugserver
interpreter = self.dbg.GetCommandInterpreter()
connected = False
for i in range(self.ATTEMPTS):
result = lldb.SBCommandReturnObject()
interpreter.HandleCommand("gdb-remote {}".format(self.PORT), result)
connected = result.Succeeded()
if connected:
break
time.sleep(self.TIMEOUT)
self.assertTrue(connected, "could not connect to debugserver")
# Make sure the image was loaded from the 'SDK'.
self.expect("image list", substrs=[exe_sdk_path])