7f4c297e94
`Predicates` and `Features` fields serve the same purpose. They should be kept in sync, but not all predicates are based on features. This resulted in introducing dummy features for that only reason. This patch removes `Features` field and changes TableGen emitters to use `Predicates` instead. Historically, predicates were written with the assumption that the checking code will be used in `SelectionDAGISel` subclasses, meaning they will have access to the subclass variables, such as `Subtarget`. There are no such variables in the generated `GenSubtargetInfo::getHwModeSet()`, so we need to provide them. This can be achieved by subclassing `HwModePredicateProlog`, see an example in `Hexagon.td`.
32 lines
1.1 KiB
TableGen
32 lines
1.1 KiB
TableGen
// RUN: not llvm-tblgen -gen-dag-isel -I %p/../../include %s 2>&1 | FileCheck %s -DFILE=%s
|
|
|
|
// The HwModeSelect class is intended to serve as a base class for other
|
|
// classes that are then used to select a value based on the HW mode.
|
|
// It contains a list of HW modes, and a derived class should provide a
|
|
// list of corresponding values.
|
|
// These two lists must have the same size. Make sure that a violation of
|
|
// this requirement is diagnosed.
|
|
|
|
include "llvm/Target/Target.td"
|
|
|
|
def TestTargetInstrInfo : InstrInfo;
|
|
|
|
def TestTarget : Target {
|
|
let InstructionSet = TestTargetInstrInfo;
|
|
}
|
|
|
|
def TestReg : Register<"testreg">;
|
|
def TestClass : RegisterClass<"TestTarget", [i32], 32, (add TestReg)>;
|
|
|
|
def HasFeat1 : Predicate<"Subtarget->hasFeat1()">;
|
|
def HasFeat2 : Predicate<"Subtarget->hasFeat2()">;
|
|
|
|
def TestMode1 : HwMode<[HasFeat1]>;
|
|
def TestMode2 : HwMode<[HasFeat2]>;
|
|
|
|
// CHECK: error: assertion failed: The Objects and Modes lists must be the same length
|
|
// CHECK: [[FILE]]:[[@LINE+1]]:5: error: assertion failed in this record
|
|
def BadDef : ValueTypeByHwMode<[TestMode1, TestMode2, DefaultMode],
|
|
[i8, i16, i32, i64]>;
|
|
|