
As of rev ea222be0d, LLVMs assembler will actually try to honour the "fill value" part of p2align directives. X86 printed these as 0x90, which isn't actually what it wanted: we want multi-byte nops for .text padding. Compiling via a textual assembly file produces single-byte nop padding since ea222be0d but the built-in assembler will produce multi-byte nops. This divergent behaviour is undesirable. To fix: don't set the byte padding field for x86, which allows the assembler to pick multi-byte nops. Test that we get the same multi-byte padding when compiled via textual assembly or directly to object file. Added same-align-bytes-with-llasm-llobj.ll to that effect, updated numerous other tests to not contain check-lines for the explicit padding.
23 lines
545 B
LLVM
23 lines
545 B
LLVM
; RUN: llc -mcpu=corei7 -mtriple=x86_64-linux -align-all-blocks=16 < %s | FileCheck %s
|
|
|
|
;CHECK-LABEL: foo:
|
|
;CHECK: .p2align 16
|
|
;CHECK: .p2align 16
|
|
;CHECK: .p2align 16
|
|
;CHECK: ret
|
|
define i32 @foo(i32 %t, i32 %l) nounwind readnone ssp uwtable {
|
|
%1 = icmp eq i32 %t, 0
|
|
br i1 %1, label %4, label %2
|
|
|
|
; <label>:2 ; preds = %0
|
|
%3 = add nsw i32 %t, 2
|
|
ret i32 %3
|
|
|
|
; <label>:4 ; preds = %0
|
|
%5 = icmp eq i32 %l, 0
|
|
%. = select i1 %5, i32 0, i32 5
|
|
ret i32 %.
|
|
}
|
|
|
|
|